Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h
index 964ee4b3987a5d1c801aeec16f3cfc7390605e2c..3a5804928b085fc877c09a99d67a03ed65162b9c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h
@@ -75,15 +75,15 @@ public:
{
bool eq = given == bound;
StringBuilder result;
- result.appendLiteral("The ");
+ result.append("The ");
result.append(name);
- result.appendLiteral(" provided (");
+ result.append(" provided (");
result.append(formatNumber(given));
- result.appendLiteral(") is greater than ");
+ result.append(") is greater than ");
result.append(eq ? "or equal to " : "");
- result.appendLiteral("the maximum bound (");
+ result.append("the maximum bound (");
result.append(formatNumber(bound));
- result.appendLiteral(").");
+ result.append(").");
return result.toString();
}
@@ -92,15 +92,15 @@ public:
{
bool eq = given == bound;
StringBuilder result;
- result.appendLiteral("The ");
+ result.append("The ");
result.append(name);
- result.appendLiteral(" provided (");
+ result.append(" provided (");
result.append(formatNumber(given));
- result.appendLiteral(") is less than ");
+ result.append(") is less than ");
result.append(eq ? "or equal to " : "");
- result.appendLiteral("the minimum bound (");
+ result.append("the minimum bound (");
result.append(formatNumber(bound));
- result.appendLiteral(").");
+ result.append(").");
return result.toString();
}
@@ -108,14 +108,14 @@ public:
static String indexOutsideRange(const char* name, NumberType given, NumberType lowerBound, BoundType lowerType, NumberType upperBound, BoundType upperType)
{
StringBuilder result;
- result.appendLiteral("The ");
+ result.append("The ");
result.append(name);
- result.appendLiteral(" provided (");
+ result.append(" provided (");
result.append(formatNumber(given));
- result.appendLiteral(") is outside the range ");
+ result.append(") is outside the range ");
result.append(lowerType == ExclusiveBound ? '(' : '[');
result.append(formatNumber(lowerBound));
- result.appendLiteral(", ");
+ result.append(", ");
result.append(formatNumber(upperBound));
result.append(upperType == ExclusiveBound ? ')' : ']');
result.append('.');
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698