Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 for (unsigned index = 0; index < m_labels.size(); ++index) { 55 for (unsigned index = 0; index < m_labels.size(); ++index) {
56 if (m_labels[index] != other.m_labels[index]) 56 if (m_labels[index] != other.m_labels[index])
57 return false; 57 return false;
58 } 58 }
59 return true; 59 return true;
60 } 60 }
61 61
62 String toString() const 62 String toString() const
63 { 63 {
64 StringBuilder builder; 64 StringBuilder builder;
65 builder.appendLiteral("labels("); 65 builder.append("labels(");
66 for (unsigned index = 0; index < m_labels.size(); ++index) { 66 for (unsigned index = 0; index < m_labels.size(); ++index) {
67 if (index) 67 if (index)
68 builder.appendLiteral(", "); 68 builder.append(", ");
69 builder.append('"'); 69 builder.append('"');
70 builder.append(m_labels[index]); 70 builder.append(m_labels[index]);
71 builder.append('"'); 71 builder.append('"');
72 } 72 }
73 builder.append(')'); 73 builder.append(')');
74 return builder.toString(); 74 return builder.toString();
75 } 75 }
76 76
77 private: 77 private:
78 Vector<String> m_labels; 78 Vector<String> m_labels;
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 testNumbers("de_DE"); 285 testNumbers("de_DE");
286 testNumbers("es_ES"); 286 testNumbers("es_ES");
287 testNumbers("ja_JP"); 287 testNumbers("ja_JP");
288 testNumbers("ko_KR"); 288 testNumbers("ko_KR");
289 testNumbers("zh_CN"); 289 testNumbers("zh_CN");
290 testNumbers("zh_HK"); 290 testNumbers("zh_HK");
291 testNumbers("zh_TW"); 291 testNumbers("zh_TW");
292 } 292 }
293 293
294 } // namespace blink 294 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/text/DateTimeFormat.cpp ('k') | third_party/WebKit/Source/platform/text/LocaleWin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698