Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 result = false; 135 result = false;
136 break; 136 break;
137 } 137 }
138 } 138 }
139 m_visitedArrays.removeLast(); 139 m_visitedArrays.removeLast();
140 return result; 140 return result;
141 } 141 }
142 142
143 bool append(v8::Local<v8::Symbol> symbol) 143 bool append(v8::Local<v8::Symbol> symbol)
144 { 144 {
145 m_builder.appendLiteral("Symbol("); 145 m_builder.append("Symbol(");
146 bool result = append(symbol->Name(), IgnoreUndefined); 146 bool result = append(symbol->Name(), IgnoreUndefined);
147 m_builder.append(')'); 147 m_builder.append(')');
148 return result; 148 return result;
149 } 149 }
150 150
151 bool append(v8::Local<v8::String> string) 151 bool append(v8::Local<v8::String> string)
152 { 152 {
153 if (m_tryCatch.HasCaught()) 153 if (m_tryCatch.HasCaught())
154 return false; 154 return false;
155 if (!string.IsEmpty()) 155 if (!string.IsEmpty())
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 if (!argumentCount()) 207 if (!argumentCount())
208 return false; 208 return false;
209 209
210 const ScriptValue& value = argumentAt(0); 210 const ScriptValue& value = argumentAt(0);
211 ScriptState::Scope scope(m_scriptState.get()); 211 ScriptState::Scope scope(m_scriptState.get());
212 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate()); 212 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate());
213 return true; 213 return true;
214 } 214 }
215 215
216 } // namespace blink 216 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698