Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 } 126 }
127 if (m_cachedToImage) { 127 if (m_cachedToImage) {
128 m_cachedToImage->removeObserver(&m_crossfadeSubimageObserver); 128 m_cachedToImage->removeObserver(&m_crossfadeSubimageObserver);
129 m_cachedToImage = nullptr; 129 m_cachedToImage = nullptr;
130 } 130 }
131 } 131 }
132 132
133 String CSSCrossfadeValue::customCSSText() const 133 String CSSCrossfadeValue::customCSSText() const
134 { 134 {
135 StringBuilder result; 135 StringBuilder result;
136 result.appendLiteral("-webkit-cross-fade("); 136 result.append("-webkit-cross-fade(");
137 result.append(m_fromValue->cssText()); 137 result.append(m_fromValue->cssText());
138 result.appendLiteral(", "); 138 result.append(", ");
139 result.append(m_toValue->cssText()); 139 result.append(m_toValue->cssText());
140 result.appendLiteral(", "); 140 result.append(", ");
141 result.append(m_percentageValue->cssText()); 141 result.append(m_percentageValue->cssText());
142 result.append(')'); 142 result.append(')');
143 return result.toString(); 143 return result.toString();
144 } 144 }
145 145
146 CSSCrossfadeValue* CSSCrossfadeValue::valueWithURLsMadeAbsolute() 146 CSSCrossfadeValue* CSSCrossfadeValue::valueWithURLsMadeAbsolute()
147 { 147 {
148 CSSValue* fromValue = m_fromValue; 148 CSSValue* fromValue = m_fromValue;
149 if (m_fromValue->isImageValue()) 149 if (m_fromValue->isImageValue())
150 fromValue = toCSSImageValue(*m_fromValue).valueWithURLMadeAbsolute(); 150 fromValue = toCSSImageValue(*m_fromValue).valueWithURLMadeAbsolute();
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 visitor->trace(m_fromValue); 292 visitor->trace(m_fromValue);
293 visitor->trace(m_toValue); 293 visitor->trace(m_toValue);
294 visitor->trace(m_percentageValue); 294 visitor->trace(m_percentageValue);
295 visitor->trace(m_cachedFromImage); 295 visitor->trace(m_cachedFromImage);
296 visitor->trace(m_cachedToImage); 296 visitor->trace(m_cachedToImage);
297 visitor->trace(m_crossfadeSubimageObserver); 297 visitor->trace(m_crossfadeSubimageObserver);
298 CSSImageGeneratorValue::traceAfterDispatch(visitor); 298 CSSImageGeneratorValue::traceAfterDispatch(visitor);
299 } 299 }
300 300
301 } // namespace blink 301 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSCounterValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSFontFaceRule.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698