Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2017013004: Fixing construction arguments for NewTabPage.Snippets.CardClickedAge (Closed)

Created:
4 years, 6 months ago by jkrcal
Modified:
4 years, 6 months ago
Reviewers:
Ted C, mastiz
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 Committed: https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0 Cr-Commit-Position: refs/heads/master@{#397071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
4 years, 6 months ago (2016-05-27 13:58:16 UTC) #2
jkrcal
PTAL
4 years, 6 months ago (2016-05-27 13:58:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 14:39:57 UTC) #6
mastiz
LGTM Nit: the second line in the patch description is almost redundant. How about briefly ...
4 years, 6 months ago (2016-05-30 07:09:51 UTC) #8
Ted C
lgtm
4 years, 6 months ago (2016-05-31 18:07:47 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
4 years, 6 months ago (2016-05-31 19:15:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 20:12:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
4 years, 6 months ago (2016-06-01 05:59:24 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 06:04:06 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 06:05:46 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0
Cr-Commit-Position: refs/heads/master@{#397071}

Powered by Google App Engine
This is Rietveld 408576698