|
|
DescriptionFixing construction arguments for NewTabPage.Snippets.CardClickedAge
I had different arguments in the code that the ones with which the histogram was constructed resulting in an error:
F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50
BUG=615379
Committed: https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0
Cr-Commit-Position: refs/heads/master@{#397071}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
jkrcal@chromium.org changed reviewers: + tedchoc@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mastiz@chromium.org changed reviewers: + mastiz@chromium.org
LGTM Nit: the second line in the patch description is almost redundant. How about briefly describing the issue/crash being fixed instead?
lgtm
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
Description was changed from ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge Fixing construction arguments for a UMA histogram. BUG=615379 ========== to ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jkrcal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017013004/1
Message was sent while issue was closed.
Description was changed from ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 ========== to ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 ========== to ========== Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG=615379 Committed: https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0 Cr-Commit-Position: refs/heads/master@{#397071} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0 Cr-Commit-Position: refs/heads/master@{#397071} |