Make some pkg tests less timing-dependent.

Make some pkg tests less timing-dependent.

Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e. slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=#26556
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/2a6847de417ee88ed6e7ec55cf26d262d289d451

[Florian Schneider, 2016-05-27 12:31:37]

fschneider@google.com changed reviewers:
+ scheglov@google.com

[Florian Schneider, 2016-05-27 12:34:39]

Description was changed from

==========
Make some pkg tests less timing-dependent.

Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e.
slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=
==========

to

==========
Make some pkg tests less timing-dependent.

Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e.
slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=#26556
==========

[scheglov, 2016-05-27 15:23:42]

LGTM

[Florian Schneider, 2016-05-30 10:14:21]

Description was changed from

==========
Make some pkg tests less timing-dependent.

Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e.
slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=#26556
==========

to

==========
Make some pkg tests less timing-dependent.

Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e.
slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=#26556
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2a6847de417ee88ed6e7ec55cf26d262d289d451
==========

[Florian Schneider, 2016-05-30 10:14:22]

Committed patchset #1 (id:1) manually as
2a6847de417ee88ed6e7ec55cf26d262d289d451 (presubmit successful).