Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2016993003: [runtime] Remove the obsolete %_StringCharAt intrinsic. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove the obsolete %_StringCharAt intrinsic. This intrinsic (and the matching runtime entry) are no longer used by now and can thereby be removed. BUG=v8:5049 Committed: https://crrev.com/b2fd2ded16e9f648af468a7e9c70ff47b38d197f Cr-Commit-Position: refs/heads/master@{#36540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -456 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Jakob, Red-only, removing dead code. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-27 06:29:03 UTC) #2
jgruber
lgtm
4 years, 7 months ago (2016-05-27 08:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016993003/1
4 years, 6 months ago (2016-05-27 08:48:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 08:50:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 08:52:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2fd2ded16e9f648af468a7e9c70ff47b38d197f
Cr-Commit-Position: refs/heads/master@{#36540}

Powered by Google App Engine
This is Rietveld 408576698