Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: content/browser/bluetooth/web_bluetooth_service_impl.cc

Issue 2016973003: bluetooth: Fix logic mistake in DeviceChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/bluetooth/web_bluetooth_service_impl.cc
diff --git a/content/browser/bluetooth/web_bluetooth_service_impl.cc b/content/browser/bluetooth/web_bluetooth_service_impl.cc
index f2fa91880cb70c87cd37ae5ebe7ee73796bf0017..8e06fc7fa4505a11d53473e3a2436eba1f405533 100644
--- a/content/browser/bluetooth/web_bluetooth_service_impl.cc
+++ b/content/browser/bluetooth/web_bluetooth_service_impl.cc
@@ -217,7 +217,7 @@ void WebBluetoothServiceImpl::DeviceAdded(device::BluetoothAdapter* adapter,
void WebBluetoothServiceImpl::DeviceChanged(device::BluetoothAdapter* adapter,
device::BluetoothDevice* device) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (!device->IsGattConnected() || !device->IsConnected()) {
+ if (!device->IsGattConnected() && !device->IsConnected()) {
Jeffrey Yasskin 2016/05/28 02:48:00 Should we only check one of these? All of our conn
Jeffrey Yasskin 2016/05/28 03:49:52 Does it make sense to implement it to forward to I
ortuno 2016/05/31 16:33:21 Done. I thought it was going to be much harder so
std::string device_id =
connected_devices_->CloseConnectionToDeviceWithAddress(
device->GetAddress());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698