Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2016973003: bluetooth: Fix logic mistake in DeviceChanged (Closed)

Created:
4 years, 6 months ago by ortuno
Modified:
4 years, 6 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Fix logic mistake in DeviceChanged Fixes an issue in which we always disconnected a device even if the connection is still active. BUG=615383 Committed: https://crrev.com/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775 Cr-Commit-Position: refs/heads/master@{#396877}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Implement IsGattConnected on Bluez #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc View 1 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
ortuno
jyasskin: PTAL
4 years, 6 months ago (2016-05-27 16:09:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016973003/1
4 years, 6 months ago (2016-05-27 16:10:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 17:50:45 UTC) #6
Jeffrey Yasskin
https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc File content/browser/bluetooth/web_bluetooth_service_impl.cc (right): https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc#newcode220 content/browser/bluetooth/web_bluetooth_service_impl.cc:220: if (!device->IsGattConnected() && !device->IsConnected()) { Should we only check ...
4 years, 6 months ago (2016-05-28 02:48:01 UTC) #7
chromium-reviews
IsGattConnected is not implemented on Chrome OS yet. On Fri, May 27, 2016, 7:48 PM ...
4 years, 6 months ago (2016-05-28 03:24:44 UTC) #8
Jeffrey Yasskin
https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc File content/browser/bluetooth/web_bluetooth_service_impl.cc (right): https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc#newcode220 content/browser/bluetooth/web_bluetooth_service_impl.cc:220: if (!device->IsGattConnected() && !device->IsConnected()) { On 2016/05/28 03:24:44, chromium-reviews ...
4 years, 6 months ago (2016-05-28 03:49:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016973003/20001
4 years, 6 months ago (2016-05-31 14:57:58 UTC) #11
ortuno
https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc File content/browser/bluetooth/web_bluetooth_service_impl.cc (right): https://codereview.chromium.org/2016973003/diff/1/content/browser/bluetooth/web_bluetooth_service_impl.cc#newcode220 content/browser/bluetooth/web_bluetooth_service_impl.cc:220: if (!device->IsGattConnected() && !device->IsConnected()) { On 2016/05/28 at 03:49:52, ...
4 years, 6 months ago (2016-05-31 16:33:21 UTC) #12
Jeffrey Yasskin
Thanks! LGTM.
4 years, 6 months ago (2016-05-31 16:36:19 UTC) #13
ortuno
scheib: PTAL at device/bluetooth
4 years, 6 months ago (2016-05-31 16:37:00 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 16:44:22 UTC) #17
scheib
LGTM
4 years, 6 months ago (2016-05-31 18:34:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016973003/20001
4 years, 6 months ago (2016-05-31 18:38:52 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 18:44:14 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:45:21 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775
Cr-Commit-Position: refs/heads/master@{#396877}

Powered by Google App Engine
This is Rietveld 408576698