Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2016963002: DevTools: rework focus logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stray newline Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
index 127399500c182557787381c0b1dd1b56984091d9..176828b544dec1ae208ae4c61969f09e42930751 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
@@ -290,8 +290,6 @@ WebInspector.GlassPane.prototype = {
dispose: function()
{
delete WebInspector._glassPane;
- if (WebInspector.GlassPane.DefaultFocusedViewStack.length)
- WebInspector.GlassPane.DefaultFocusedViewStack.peekLast().focus();
this.element.remove();
}
}
@@ -300,11 +298,6 @@ WebInspector.GlassPane.prototype = {
WebInspector._glassPane;
/**
- * @type {!Array.<!WebInspector.Widget|!WebInspector.Dialog>}
- */
-WebInspector.GlassPane.DefaultFocusedViewStack = [];
-
-/**
* @param {?Node=} node
* @return {boolean}
*/
@@ -1631,11 +1624,6 @@ WebInspector.bindInput = function(input, apply, validate, numeric)
var valid = validate(value);
input.classList.toggle("error-input", !valid);
input.value = value;
-
- // Selection range operations are not supported by type "number" inputs. This browser
- // behavior is detailed by the WHATWG forms spec.
- if (input.type !== "number")
- input.setSelectionRange(value.length, value.length);
}
return setValue;

Powered by Google App Engine
This is Rietveld 408576698