third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js - Issue 2016963002: DevTools: rework focus logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js

Issue 2016963002: DevTools: rework focus logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move Dialog logic into Dialog; opening tabs will focus if no focus was set Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/ui/Dialog.js ('K') | « third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js b/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js

index a0137429fef72b7c1cfb7563dfce843287883482..ae3e4b3622630a6b86e95eec201f592c56004c31 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js

@@ -90,7 +90,7 @@ WebInspector.ShortcutRegistry.prototype = {

var actions = this._applicableActions(key);

if (!actions.length)

return;

- if (WebInspector.GlassPane.DefaultFocusedViewStack.length > 1) {

+ if (WebInspector.Dialog.hasInstance()) {

if (event && !isPossiblyInputKey())

event.consume(true);

return;