DevTools: rework focus logic

third_party/WebKit/Source/devtools/front_end/ui/Drawer.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 50 matching lines @@
 }
 
 WebInspector.Drawer.prototype = {
     /**
      * @param {string} id
      * @param {boolean=} immediate
      * @return {!Promise.<?WebInspector.Widget>}
      */
     showView: function(id, immediate)
     {
+        /**
+         * @param {?WebInspector.Widget} view
+         * @return {?WebInspector.Widget} view
+         * @this {WebInspector.Drawer}
+         */
+        function tabViewLoaded(view)
+        {
+            this.focus();

[dgozman, 2016/05/31 19:30:42]

I think you can call |this.focus()| right after |_innerShow| due to the focus
preserving logic in TabbedPane.

[luoe, 2016/05/31 21:22:54]

This would cover most cases, but there is one case when calling focus() right
after innerShow doesn't work.  If we did that, the TabbedPane logic relies on
the assumption that after calling Drawer.focus(), the Drawer.hasFocus() == true
before TabbedPane.showTab() is called.  However, certain tabs (e.g. Rendering)
do not have a default focus element, so calling Drawer.focus() doesn't actually
focus the Drawer (hasFocus == false).

+            return view;
+        }
+
         this._innerShow(immediate);
         WebInspector.userMetrics.drawerShown(id);
-        return this._extensibleTabbedPaneController.showTab(id);
+        return this._extensibleTabbedPaneController.showTab(id).then(tabViewLoaded.bind(this));
     },
 
     showDrawer: function()
     {
         this._innerShow();
     },
 
     wasShown: function()
     {
         var id = this._lastSelectedViewSetting.get();
@@ skipping 64 matching lines @@
         return this._tabbedPane.selectedTabId;
     },
 
     initialPanelShown: function()
     {
         this._initialPanelWasShown = true;
     },
 
     __proto__: WebInspector.VBox.prototype
 }