DevTools: rework focus logic

third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 304 matching lines @@
 
     /**
      * @param {string} id
      * @param {boolean=} userGesture
      * @return {boolean}
      */
     selectTab: function(id, userGesture)
     {
         if (this._currentTabLocked)
             return false;
-        var focused = this.hasFocus();
+        var shouldFocus = this.hasFocus() || !WebInspector.currentFocusElement();

[dgozman, 2016/05/27 01:05:59]

This looks strange. The logic here was preserving focus. If you want to focus
specific tabbed pane on selection, should do it on the callsite.

[lushnikov, 2016/05/27 01:14:44]

maybe focusing iff userGesture would work as well

[luoe, 2016/05/27 23:20:40]

Almost, but it didn't cover all the cases.

[luoe, 2016/05/27 23:20:40]

Yeah, it is strange.  The condition has been reverted.  Since calling focus() on
show() is specific to drawer tabs, I added a focus() call in Drawer.showView().

         var tab = this._tabsById[id];
         if (!tab)
             return false;
         if (this._currentTab && this._currentTab.id === id)
             return true;
 
         this._hideCurrentTab();
         this._showTab(tab);
         this._currentTab = tab;
 
         this._tabsHistory.splice(this._tabsHistory.indexOf(tab), 1);
         this._tabsHistory.splice(0, 0, tab);
 
         this._updateTabElements();
-        if (focused)
+        if (shouldFocus)
             this.focus();
 
         var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
         this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabSelected, eventData);
         return true;
     },
 
     /**
      * @param {number} tabsCount
      * @return {!Array.<string>}
@@ skipping 1079 matching lines @@
             if (this._viewCallback && view)
                 this._viewCallback(id, view);
             var shouldFocus = this._tabbedPane.visibleView.element.isSelfOrAncestor(WebInspector.currentFocusElement());
             this._tabbedPane.changeTabView(id, view);
             if (shouldFocus)
                 view.focus();
             return view;
         }
     }
 }