Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2016883002: exo: Remote shell surfaces are not yet resizeable. (Closed)

Created:
4 years, 6 months ago by reveman
Modified:
4 years, 6 months ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Remote shell surfaces are not yet resizeable. This was accidentally set to true in last version of remote shell patch. Should have always been false. BUG=549781 TEST=exo_unittests Committed: https://crrev.com/e623eb7cd1fc6d7cef93a133c4742c42da96b76c Cr-Commit-Position: refs/heads/master@{#396300}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M components/exo/display.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reveman
4 years, 6 months ago (2016-05-26 21:07:23 UTC) #2
Daniele Castagna
LGTM. https://codereview.chromium.org/2016883002/diff/1/components/exo/display.cc File components/exo/display.cc (left): https://codereview.chromium.org/2016883002/diff/1/components/exo/display.cc#oldcode145 components/exo/display.cc:145: true, true, container)); nit: maybe you can name ...
4 years, 6 months ago (2016-05-26 21:08:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016883002/20001
4 years, 6 months ago (2016-05-26 21:13:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-26 22:26:10 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 22:27:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e623eb7cd1fc6d7cef93a133c4742c42da96b76c
Cr-Commit-Position: refs/heads/master@{#396300}

Powered by Google App Engine
This is Rietveld 408576698