Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2016863004: Removed the isTimeHighResolutionHeuristic_ heuristic. (Closed)

Created:
4 years, 6 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 6 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Removed the isTimeHighResolutionHeuristic_ heuristic. It's popping up a lot of false positives, and all Chrome traces we're interested in should have the explicit flag now. The warning dialog will now only pop up if the flag is explicitly set in the trace metadata, and is false. R=sullivan@chromium.org BUG=catapult:#2368 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/16a0469e55a7cd34de8a95eeedd25e7f540133ab

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -66 lines) Patch
M tracing/tracing/model/model.html View 1 3 chunks +1 line, -39 lines 0 comments Download
M tracing/tracing/model/model_test.html View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
oystein (OOO til 10th of July)
ptal!
4 years, 6 months ago (2016-05-27 22:33:40 UTC) #4
sullivan
lgtm
4 years, 6 months ago (2016-05-27 22:34:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016863004/20001
4 years, 6 months ago (2016-06-02 22:07:14 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:47:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698