Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201683003: Remove resetStyleInheritance. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov, rune
CC:
blink-reviews, arv+blink, chromiumbugtracker_adobe.com, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, watchdog-blink-watchlist_google.com, Inactive, rwlbuis
Visibility:
Public.

Description

Remove resetStyleInheritance. BUG=353087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169430

Patch Set 1 #

Patch Set 2 : Updated TestExpectations for w3c tests #

Patch Set 3 : Resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -524 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-wrapper-reclaimed.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance.html View 1 chunk +0 lines, -150 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-root-resetStyleInheritance.html View 1 chunk +0 lines, -168 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html View 1 chunk +0 lines, -49 lines 0 comments Download
M LayoutTests/fast/dom/shadow/text-node-in-shadow.html View 3 chunks +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/dom/shadow/text-node-in-shadow-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ElementResolveContext.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/resolver/ElementResolveContext.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeWalker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ComposedTreeWalker.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLContentElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLShadowElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
hayato
I won't land this patch until we can confirm no one uses resetStyleInheritance.
6 years, 9 months ago (2014-03-17 09:30:37 UTC) #1
rune
rslgtm (no opinions about use of resetStyleInheritance)
6 years, 9 months ago (2014-03-17 13:08:48 UTC) #2
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-18 06:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/201683003/20001
6 years, 9 months ago (2014-03-18 06:33:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 06:33:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-18 06:33:53 UTC) #6
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-18 06:43:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/201683003/40001
6 years, 9 months ago (2014-03-18 06:43:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 07:53:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-18 07:53:36 UTC) #10
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 07:55:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/201683003/40001
6 years, 9 months ago (2014-03-18 07:56:04 UTC) #12
esprehn
lgtm
6 years, 9 months ago (2014-03-18 07:56:13 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 08:30:57 UTC) #14
Message was sent while issue was closed. 
Change committed as 169430

Powered by Google App Engine
This is Rietveld 408576698