Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201683002: DevTools: track stylesheets by document, not local frame. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
vsevik, lushnikov
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, alph+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, Inactive, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

DevTools: track stylesheets by document, not local frame. R=lushnikov@chromium.org, vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169354

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl dcommit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 6 chunks +28 lines, -24 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-17 09:20:42 UTC) #1
lushnikov
https://codereview.chromium.org/201683002/diff/1/Source/core/inspector/InspectorController.h File Source/core/inspector/InspectorController.h (right): https://codereview.chromium.org/201683002/diff/1/Source/core/inspector/InspectorController.h#newcode151 Source/core/inspector/InspectorController.h:151: InspectorCSSAgent* m_cssAgent; do we need these chagnes?
6 years, 9 months ago (2014-03-17 09:37:19 UTC) #2
lushnikov
lgtm
6 years, 9 months ago (2014-03-17 09:46:44 UTC) #3
vsevik
lgtm
6 years, 9 months ago (2014-03-17 09:54:32 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-17 12:42:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/201683002/1
6 years, 9 months ago (2014-03-17 12:42:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 13:21:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-17 13:21:02 UTC) #8
pfeldman
https://chromiumcodereview.appspot.com/201683002/diff/1/Source/core/inspector/InspectorController.h File Source/core/inspector/InspectorController.h (right): https://chromiumcodereview.appspot.com/201683002/diff/1/Source/core/inspector/InspectorController.h#newcode151 Source/core/inspector/InspectorController.h:151: InspectorCSSAgent* m_cssAgent; On 2014/03/17 09:37:20, lushnikov wrote: > do ...
6 years, 9 months ago (2014-03-17 13:47:41 UTC) #9
pfeldman
6 years, 9 months ago (2014-03-17 14:01:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r169354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698