Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2016773002: Clean up GPU Rasterization versions of Smoothness benchmarks (Closed)

Created:
4 years, 7 months ago by ericrk
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With Mac now running with GPU rasterization enabled by default, we can remove Mac from a number of the GPU rasterization benchmarks, and remove some that were only run on mac. BUG=609523 Committed: https://crrev.com/dae5ac0c4418d454baa570b80d4b5bc23f00149d Cr-Commit-Position: refs/heads/master@{#396330}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M tools/perf/benchmarks/smoothness.py View 1 6 chunks +9 lines, -21 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
ericrk
https://codereview.chromium.org/2016773002/diff/20001/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (left): https://codereview.chromium.org/2016773002/diff/20001/tools/perf/benchmarks/smoothness.py#oldcode332 tools/perf/benchmarks/smoothness.py:332: @benchmark.Enabled('chromeos', 'mac') This never ran on ChromeOS - adding ...
4 years, 7 months ago (2016-05-26 18:18:52 UTC) #4
nednguyen
lgtm
4 years, 7 months ago (2016-05-26 18:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016773002/20001
4 years, 7 months ago (2016-05-26 19:03:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/builds/201)
4 years, 7 months ago (2016-05-26 22:50:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016773002/20001
4 years, 7 months ago (2016-05-26 23:43:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-27 00:34:15 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 00:36:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dae5ac0c4418d454baa570b80d4b5bc23f00149d
Cr-Commit-Position: refs/heads/master@{#396330}

Powered by Google App Engine
This is Rietveld 408576698