Add back-pointer to "Associated widget" to CFWL_WidgetImp.

Add back-pointer to "Associated widget" to CFWL_WidgetImp.

This is the last use of CFX_PrivateData, which is now removed.

Committed: https://pdfium.googlesource.com/pdfium/+/a54bc400fa69491ad72ad97f74742ec28cbe849a

[Tom Sepez, 2016-05-26 18:13:51]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-26 18:13:52]

Lei, for review.

Requires https://codereview.chromium.org/2010923002/

https://codereview.chromium.org/2016743002/diff/1/core/fxcrt/include/fx_basic.h
File core/fxcrt/include/fx_basic.h (right):

https://codereview.chromium.org/2016743002/diff/1/core/fxcrt/include/fx_basic...
core/fxcrt/include/fx_basic.h:621: typedef void (*PD_CALLBACK_FREEDATA)(void*
pData);
Note: Still used in XFA in other places than with privatedata.

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/ifwl_widget.h#...
xfa/fwl/core/ifwl_widget.h:21: //                              m_pAssociate
Let me know if you can think of a better term that doesn't also connotate a
widget in the same hierarchy or a parent widget in a tree.

[Lei Zhang, 2016-05-26 23:06:07]

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:537: m_pLayoutItem(nullptr),
Initialize |m_pAssociate| ?

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/ifwl_widget.h#...
xfa/fwl/core/ifwl_widget.h:21: //                              m_pAssociate
On 2016/05/26 18:13:52, Tom Sepez wrote:
> Let me know if you can think of a better term that doesn't also connotate a
> widget in the same hierarchy or a parent widget in a tree.

Nope.

[Tom Sepez, 2016-05-27 17:15:40]

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2016743002/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:537: m_pLayoutItem(nullptr),
On 2016/05/26 23:06:07, Lei Zhang wrote:
> Initialize |m_pAssociate| ?

Done.

[Lei Zhang, 2016-05-27 17:46:43]

lgtm

[Tom Sepez, 2016-05-27 18:02:31]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-05-27 18:02:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016743002/40001

[commit-bot: I haz the power, 2016-05-27 18:13:11]

Description was changed from

==========
Add back-pointer to "Associated widget" to CFWL_WidgetImp.

This is the last use of CFX_PrivateData, which is now removed.
==========

to

==========
Add back-pointer to "Associated widget" to CFWL_WidgetImp.

This is the last use of CFX_PrivateData, which is now removed.

Committed:
https://pdfium.googlesource.com/pdfium/+/a54bc400fa69491ad72ad97f74742ec28cbe...
==========

[commit-bot: I haz the power, 2016-05-27 18:13:12]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/a54bc400fa69491ad72ad97f74742ec28cbe...