Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 201673004: Allow createBuffer to support rates from 3-192 kHz. (Closed)

Created:
6 years, 9 months ago by Raymond Toy (Google)
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Allow createBuffer to support rates from 3-192 kHz. The spec requires a minimum range of 22.05-96 kHz. (http://webaudio.github.io/web-audio-api/#widl-AudioContext-createBuffer-AudioBuffer-unsigned-long-numberOfChannels-unsigned-long-length-float-sampleRate) Add two new tests to verify that 3 kHz and 192 kHz are allowed and update expected test results for allowed range. BUG=344375 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M LayoutTests/webaudio/dom-exceptions.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/dom-exceptions-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Raymond Toy
PTAL.
6 years, 9 months ago (2014-03-24 20:23:25 UTC) #1
Raymond Toy
PTAL
6 years, 9 months ago (2014-03-25 16:34:58 UTC) #2
Ken Russell (switch to Gerrit)
LGTM I'd wonder whether new tests should be added that verify that these various sample ...
6 years, 9 months ago (2014-03-25 17:43:23 UTC) #3
Raymond Toy
On 2014/03/25 17:43:23, Ken Russell wrote: > LGTM > > I'd wonder whether new tests ...
6 years, 9 months ago (2014-03-25 18:25:21 UTC) #4
Ken Russell (switch to Gerrit)
On 2014/03/25 18:25:21, Raymond Toy wrote: > On 2014/03/25 17:43:23, Ken Russell wrote: > > ...
6 years, 9 months ago (2014-03-25 18:33:49 UTC) #5
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 9 months ago (2014-03-25 19:45:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/201673004/1
6 years, 9 months ago (2014-03-25 19:45:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 20:58:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 20:58:09 UTC) #9
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 9 months ago (2014-03-25 22:19:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/201673004/1
6 years, 9 months ago (2014-03-25 22:19:04 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 23:51:19 UTC) #12
Message was sent while issue was closed.
Change committed as 169980

Powered by Google App Engine
This is Rietveld 408576698