LayoutTests/fast/svg/animation-events.html - Issue 201673003: [SVG2] Add onbegin, onend and onrepeat EventHandlers on SVGAnimationElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/svg/animation-events.html

Issue 201673003: [SVG2] Add onbegin, onend and onrepeat EventHandlers on SVGAnimationElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: test expectations Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/script-tests/event-attribute-availability.js ('k') | LayoutTests/fast/svg/script-tests/animation-events.js » ('j') | LayoutTests/fast/svg/script-tests/animation-events.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>GlobalEventHandlers test</title>
	fs 2014/03/17 14:35:27 Nit: "Animation events test" (or something - not " Nit: "Animation events test" (or something - not "GlobalEventHandlers" though) Erik Dahlström (inactive) 2014/03/17 15:52:37 Done. Show quoted text On 2014/03/17 14:35:27, fs wrote: > Nit: "Animation events test" (or something - not "GlobalEventHandlers" though) Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="script-tests/animation-events.js"></script>

	6 <script>

	7 [

	8 "onbegin",

	9 "onend",

	10 "onrepeat"

	11 ].forEach(function(attribute) {

	12 testSet("SVGAnimateElement", attribute);
	fs 2014/03/17 14:35:27 Nested forEach? =) (I think that would help readab Nested forEach? =) (I think that would help readability a bit actually) Erik Dahlström (inactive) 2014/03/17 15:52:37 Somewhat changed now due to the added eventname te Show quoted text On 2014/03/17 14:35:27, fs wrote: > Nested forEach? =) (I think that would help readability a bit actually) Somewhat changed now due to the added eventname test.
	13 testEnumerate("SVGAnimateElement", attribute);

	14 testReflect("SVGAnimateElement", attribute);

	15 testSet("SVGAnimateMotionElement", attribute);

	16 testEnumerate("SVGAnimateMotionElement", attribute);

	17 testReflect("SVGAnimateMotionElement", attribute);

	18 testSet("SVGAnimateTransformElement", attribute);

	19 testEnumerate("SVGAnimateTransformElement", attribute);

	20 testReflect("SVGAnimateTransformElement", attribute);

	21 testSet("SVGSetElement", attribute);

	22 testEnumerate("SVGSetElement", attribute);

	23 testReflect("SVGSetElement", attribute);

	24 });

	25 </script>
	fs 2014/03/17 14:35:27 Any way to test that the mapping works? Any way to test that the mapping works? Erik Dahlström (inactive) 2014/03/17 15:52:37 The event -> attribute name? Sure, I can add that. Show quoted text On 2014/03/17 14:35:27, fs wrote: > Any way to test that the mapping works? The event -> attribute name? Sure, I can add that.
	26 <div id="log"></div>

OLD	NEW