[SVG2] Add onbegin, onend and onrepeat EventHandlers on SVGAnimationElement

[SVG2] Add onbegin, onend and onrepeat EventHandlers on SVGAnimationElement

These map to the eventnames 'beginEvent', 'endEvent' and 'repeatEvent'
respectively.

Spec:
https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement

BUG=338288
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169871

[fs, 2014-03-17 14:35:26]

Non-owner LGTM w/ a few nits.

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
File LayoutTests/fast/svg/animation-events.html (right):

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:2: <title>GlobalEventHandlers
test</title>
Nit: "Animation events test" (or something - not "GlobalEventHandlers" though)

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:12: testSet("SVGAnimateElement",
attribute);
Nested forEach? =) (I think that would help readability a bit actually)

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:25: </script>
Any way to test that the mapping works?

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
File LayoutTests/fast/svg/script-tests/animation-events.js (right):

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
LayoutTests/fast/svg/script-tests/animation-events.js:3: case
"SVGAnimateElement":
Alternatively extend the "original" getObject with the animation interfaces, and
avoid having to duplicate the test-generators below. Or do you think they'll
require modifications eventually?

[Erik Dahlström (inactive), 2014-03-17 15:52:36]

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
File LayoutTests/fast/svg/animation-events.html (right):

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:2: <title>GlobalEventHandlers
test</title>
On 2014/03/17 14:35:27, fs wrote:
> Nit: "Animation events test" (or something - not "GlobalEventHandlers" though)

Done.

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:12: testSet("SVGAnimateElement",
attribute);
On 2014/03/17 14:35:27, fs wrote:
> Nested forEach? =) (I think that would help readability a bit actually)

Somewhat changed now due to the added eventname test.

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/ani...
LayoutTests/fast/svg/animation-events.html:25: </script>
On 2014/03/17 14:35:27, fs wrote:
> Any way to test that the mapping works?

The event -> attribute name? Sure, I can add that.

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
File LayoutTests/fast/svg/script-tests/animation-events.js (right):

https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
LayoutTests/fast/svg/script-tests/animation-events.js:3: case
"SVGAnimateElement":
On 2014/03/17 14:35:27, fs wrote:
> Alternatively extend the "original" getObject with the animation interfaces,
and
> avoid having to duplicate the test-generators below. Or do you think they'll
> require modifications eventually?

You mean add to LayoutTests/fast/dom/script-tests/event-handlers.js instead? I
opted for not doing that because of the special eventname -> attribute mapping
for animation events, and because the EventHandler attributes are specific to
the animation elements.

I can certainly merge the added test into the existing one if you think that's
better.

[fs, 2014-03-17 16:07:00]

On 2014/03/17 15:52:36, Erik Dahlström wrote:
>
https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
> File LayoutTests/fast/svg/script-tests/animation-events.js (right):
> 
>
https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
> LayoutTests/fast/svg/script-tests/animation-events.js:3: case
> "SVGAnimateElement":
> On 2014/03/17 14:35:27, fs wrote:
> > Alternatively extend the "original" getObject with the animation interfaces,
> and
> > avoid having to duplicate the test-generators below. Or do you think they'll
> > require modifications eventually?
> 
> You mean add to LayoutTests/fast/dom/script-tests/event-handlers.js instead? I
> opted for not doing that because of the special eventname -> attribute mapping
> for animation events, and because the EventHandler attributes are specific to
> the animation elements.

Ok, fair enough I suppose.

[pdr., 2014-03-24 16:12:54]

On 2014/03/17 16:07:00, fs wrote:
> On 2014/03/17 15:52:36, Erik Dahlström wrote:
> >
>
https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
> > File LayoutTests/fast/svg/script-tests/animation-events.js (right):
> > 
> >
>
https://codereview.chromium.org/201673003/diff/20001/LayoutTests/fast/svg/scr...
> > LayoutTests/fast/svg/script-tests/animation-events.js:3: case
> > "SVGAnimateElement":
> > On 2014/03/17 14:35:27, fs wrote:
> > > Alternatively extend the "original" getObject with the animation
interfaces,
> > and
> > > avoid having to duplicate the test-generators below. Or do you think
they'll
> > > require modifications eventually?
> > 
> > You mean add to LayoutTests/fast/dom/script-tests/event-handlers.js instead?
I
> > opted for not doing that because of the special eventname -> attribute
mapping
> > for animation events, and because the EventHandler attributes are specific
to
> > the animation elements.
> 
> Ok, fair enough I suppose.

LGTM

[pdr., 2014-03-24 16:12:57]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-24 16:13:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/201673003/40001

[commit-bot: I haz the power, 2014-03-24 17:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:13:59]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pdr., 2014-03-24 17:15:33]

On 2014/03/24 17:13:59, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on win_blink_rel

It's too early in the week for flakes :<

[pdr., 2014-03-24 17:15:36]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:15:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/201673003/40001

[commit-bot: I haz the power, 2014-03-24 17:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:19:36]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pdr., 2014-03-24 17:24:49]

On 2014/03/24 17:19:36, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on win_blink_rel

More flakes :( This specific issue is being addressed by Pawel.

One more try, then I'll give up and use NOTRY=true

[pdr., 2014-03-24 17:24:53]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/201673003/40001

[commit-bot: I haz the power, 2014-03-24 17:25:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:25:43]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[pdr., 2014-03-24 17:30:12]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-24 17:30:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/201673003/40001

[commit-bot: I haz the power, 2014-03-24 18:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:04:29]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pdr., 2014-03-24 18:05:36]

On 2014/03/24 18:04:29, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on win_blink_rel

I'm going to NOTRY=true

[pdr., 2014-03-24 18:05:54]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-24 18:05:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/201673003/40001

[commit-bot: I haz the power, 2014-03-24 18:06:21]

Change committed as 169871