Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2016643002: Do not update, and return the previous matrix if surface_texture_ is null. (Closed)

Created:
4 years, 7 months ago by Tobias Sargeant
Modified:
4 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not update, and return the previous matrix if surface_texture_ is null. surface_texture_ should only be null during stub destruction; returning the previous matrix will allow the last frame to be redrawn correctly. BUG=614224 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/42b137d8600104c1853de10626f6ef1e15e972ab Cr-Commit-Position: refs/heads/master@{#396442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gpu/ipc/service/stream_texture_android.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tobias Sargeant
4 years, 7 months ago (2016-05-26 09:11:02 UTC) #3
no sievers
lgtm, thanks!
4 years, 7 months ago (2016-05-26 21:20:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016643002/1
4 years, 7 months ago (2016-05-27 10:51:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-27 11:55:57 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 11:57:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42b137d8600104c1853de10626f6ef1e15e972ab
Cr-Commit-Position: refs/heads/master@{#396442}

Powered by Google App Engine
This is Rietveld 408576698