Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016583002: mojo/converters/ime,display -> ui/platform_window,display/mojo (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@converters_surfaces
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo/converters/ime,display -> ui/platform_window,display/mojo R=sky@chromium.org TBR=tsepez@chromium.org BUG= Committed: https://crrev.com/8f326c614a0e24104d8bff016aa238dc6351ed24 Cr-Commit-Position: refs/heads/master@{#396528}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -437 lines) Patch
M components/mus/public/interfaces/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/test_wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/test_wm/test_wm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/converters/ime/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/converters/ime/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D mojo/converters/ime/ime_type_converters.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/converters/ime/ime_type_converters.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/converters/ime/mojo_ime_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
A + ui/display/mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/mojo/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/display/mojo/display_type_converters.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/display/mojo/display_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/mojo/mojo_display_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
D ui/gfx/geometry/mojo/mojo_bindings.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
D ui/mojo/display/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/mojo/display/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/mojo/display/display_type_converters.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/mojo/display/display_type_converters.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/mojo/display/mojo_display_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/mojo/ime/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/mojo/ime/text_input_state.mojom View 1 chunk +0 lines, -70 lines 0 comments Download
A + ui/platform_window/mojo/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
A + ui/platform_window/mojo/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + ui/platform_window/mojo/ime_type_converters.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/platform_window/mojo/ime_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/platform_window/mojo/mojo_ime_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/platform_window/mojo/text_input_state.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/input_method_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (13 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-26 00:01:03 UTC) #1
sky
Rubber stamp LGTM
4 years, 7 months ago (2016-05-26 03:58:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016583002/1
4 years, 6 months ago (2016-05-26 20:57:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/190677)
4 years, 6 months ago (2016-05-26 21:06:27 UTC) #6
Ben Goodger (Google)
tbr tsepez... simple file move fyi.
4 years, 6 months ago (2016-05-27 00:00:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016583002/1
4 years, 6 months ago (2016-05-27 00:00:54 UTC) #11
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 00:05:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/190861)
4 years, 6 months ago (2016-05-27 00:10:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016583002/20001
4 years, 6 months ago (2016-05-27 17:51:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/73067) android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-05-27 17:55:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016583002/40001
4 years, 6 months ago (2016-05-27 18:10:09 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-27 19:11:31 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 19:12:51 UTC) #26
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8f326c614a0e24104d8bff016aa238dc6351ed24
Cr-Commit-Position: refs/heads/master@{#396528}

Powered by Google App Engine
This is Rietveld 408576698