Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016543002: Resynthesize FieldFormalParameterElementImpl(s) lazily. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize FieldFormalParameterElementImpl(s) lazily. And also resynthesize parameter types lazily. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ac7f892cc41f18b2408c0279e0c3d03fef923cde

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -70 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/analyzer/lib/src/dart/element/element.dart View 8 chunks +134 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 7 chunks +25 lines, -58 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-25 22:27:14 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2016543002/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart File pkg/analyzer/lib/src/dart/element/builder.dart (right): https://codereview.chromium.org/2016543002/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart#newcode1306 pkg/analyzer/lib/src/dart/element/builder.dart:1306: _fieldMap[field.name] ??= field; Inline field to avoid a ...
4 years, 7 months ago (2016-05-25 23:14:49 UTC) #2
Paul Berry
lgtm
4 years, 7 months ago (2016-05-26 11:38:16 UTC) #3
scheglov
4 years, 7 months ago (2016-05-26 15:36:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac7f892cc41f18b2408c0279e0c3d03fef923cde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698