Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20165002: Move webkit/plugins/ppapi to content/renderer/pepper. (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Move webkit/plugins/ppapi to content/renderer/pepper. I will change namespaces in a followup as this got very large. Also, I have a temporary dependency from content/common onto content/renderer for PluginModule that I only discovered at the end. I will remove that in a followup. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213578

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix clang, content_unittests and checkdeps #

Patch Set 3 : more clang #

Patch Set 4 : more clang #

Patch Set 5 : more more clang fun #

Patch Set 6 : more more clang fun #

Unified diffs Side-by-side diffs Delta from patch set Stats (+872 lines, -20372 lines) Patch
M chrome/browser/component_updater/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_fullscreen_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_shared_memory_message_filter.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 1 2 3 4 5 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 4 chunks +91 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 5 chunks +19 lines, -19 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 2 3 4 5 2 chunks +16 lines, -2 lines 0 comments Download
M content/public/common/pepper_plugin_info.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A + content/public/renderer/ppapi_plugin_instance.h View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_destination_handler.cc View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
A + content/renderer/pepper/DEPS View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M content/renderer/pepper/OWNERS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A + content/renderer/pepper/audio_helper.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/audio_helper.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
A + content/renderer/pepper/common.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/content_decryptor_delegate.h View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/content_decryptor_delegate.cc View 1 2 3 4 5 3 chunks +5 lines, -2 lines 0 comments Download
A + content/renderer/pepper/event_conversion.h View 1 2 3 4 5 3 chunks +4 lines, -5 lines 0 comments Download
A + content/renderer/pepper/event_conversion.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/fullscreen_container.h View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
A + content/renderer/pepper/gfx_conversion.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/host_array_buffer_var.h View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
A + content/renderer/pepper/host_array_buffer_var.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/host_globals.h View 1 2 3 4 5 3 chunks +6 lines, -7 lines 0 comments Download
A + content/renderer/pepper/host_globals.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/host_var_tracker.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/host_var_tracker.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/host_var_tracker_unittest.cc View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
A + content/renderer/pepper/message_channel.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/message_channel.cc View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
A + content/renderer/pepper/mock_platform_image_2d.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/mock_platform_image_2d.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/mock_plugin_delegate.h View 1 2 3 4 5 3 chunks +99 lines, -91 lines 0 comments Download
A + content/renderer/pepper/mock_plugin_delegate.cc View 1 2 3 4 5 2 chunks +5 lines, -17 lines 0 comments Download
A + content/renderer/pepper/mock_resource.h View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
A + content/renderer/pepper/npapi_glue.h View 1 2 3 4 5 4 chunks +9 lines, -11 lines 0 comments Download
A + content/renderer/pepper/npapi_glue.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
A + content/renderer/pepper/npobject_var.h View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/pepper/npobject_var.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_audio_input_host.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_audio_input_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_broker_impl.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_event_handler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_host_helper.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_host_helper_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_file_io_host.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_file_system_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_image_2d_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 3 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_url_loader_host.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_url_request_unittest.cc View 1 2 3 4 5 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_destination_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_source_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
A + content/renderer/pepper/plugin_delegate.h View 1 2 3 4 5 6 chunks +5 lines, -25 lines 0 comments Download
A + content/renderer/pepper/plugin_module.h View 1 2 3 4 5 9 chunks +15 lines, -31 lines 0 comments Download
A + content/renderer/pepper/plugin_module.cc View 1 2 3 4 5 14 chunks +30 lines, -35 lines 0 comments Download
A + content/renderer/pepper/plugin_object.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/plugin_object.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/ppapi_interface_factory.h View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/pepper/ppapi_interface_factory.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/ppapi_plugin_instance_impl.h View 1 2 3 4 5 8 chunks +36 lines, -33 lines 0 comments Download
A + content/renderer/pepper/ppapi_plugin_instance_impl.cc View 1 2 3 4 5 4 chunks +20 lines, -17 lines 0 comments Download
A + content/renderer/pepper/ppapi_plugin_instance_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/ppapi_unittest.h View 1 2 3 4 5 3 chunks +5 lines, -9 lines 0 comments Download
A + content/renderer/pepper/ppapi_unittest.cc View 1 2 3 4 5 3 chunks +9 lines, -13 lines 0 comments Download
A + content/renderer/pepper/ppapi_webplugin_impl.h View 1 2 3 4 5 5 chunks +8 lines, -10 lines 0 comments Download
A + content/renderer/pepper/ppapi_webplugin_impl.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_audio_impl.h View 1 2 3 4 5 6 chunks +9 lines, -9 lines 0 comments Download
A + content/renderer/pepper/ppb_audio_impl.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_broker_impl.h View 1 2 3 4 5 3 chunks +8 lines, -10 lines 0 comments Download
A + content/renderer/pepper/ppb_broker_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_buffer_impl.h View 1 2 3 4 5 4 chunks +7 lines, -9 lines 0 comments Download
A + content/renderer/pepper/ppb_buffer_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/ppb_file_ref_impl.h View 1 2 3 4 5 6 chunks +7 lines, -8 lines 0 comments Download
A + content/renderer/pepper/ppb_file_ref_impl.cc View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
A + content/renderer/pepper/ppb_flash_message_loop_impl.h View 1 2 3 4 5 4 chunks +4 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_flash_message_loop_impl.cc View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
A + content/renderer/pepper/ppb_gpu_blacklist_private_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_gpu_blacklist_private_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/ppb_graphics_3d_impl.h View 1 2 3 4 5 3 chunks +5 lines, -6 lines 0 comments Download
A + content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/ppb_image_data_impl.h View 1 2 3 4 5 6 chunks +10 lines, -9 lines 0 comments Download
A + content/renderer/pepper/ppb_image_data_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_network_monitor_private_impl.h View 1 2 3 4 5 4 chunks +5 lines, -6 lines 0 comments Download
A + content/renderer/pepper/ppb_network_monitor_private_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/pepper/ppb_proxy_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_proxy_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_scrollbar_impl.h View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/pepper/ppb_scrollbar_impl.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/pepper/ppb_tcp_server_socket_private_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_tcp_server_socket_private_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_tcp_socket_private_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_tcp_socket_private_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_uma_private_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_uma_private_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/ppb_var_deprecated_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_var_deprecated_impl.cc View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
A + content/renderer/pepper/ppb_video_decoder_impl.h View 1 2 3 4 5 4 chunks +6 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_video_decoder_impl.cc View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
A + content/renderer/pepper/ppb_widget_impl.h View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
A + content/renderer/pepper/ppb_widget_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/ppb_x509_certificate_private_impl.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppb_x509_certificate_private_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/ppp_pdf.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/quota_file_io.h View 1 2 3 4 5 4 chunks +20 lines, -20 lines 0 comments Download
A + content/renderer/pepper/quota_file_io.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/quota_file_io_unittest.cc View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/pepper/resource_creation_impl.h View 1 2 3 4 5 3 chunks +4 lines, -6 lines 0 comments Download
A + content/renderer/pepper/resource_creation_impl.cc View 1 2 3 4 5 1 chunk +16 lines, -16 lines 0 comments Download
A + content/renderer/pepper/resource_helper.h View 1 2 3 4 5 3 chunks +4 lines, -6 lines 0 comments Download
A + content/renderer/pepper/resource_helper.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + content/renderer/pepper/url_request_info_util.h View 1 2 3 4 5 2 chunks +8 lines, -9 lines 0 comments Download
A + content/renderer/pepper/url_request_info_util.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/url_response_info_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/usb_key_code_conversion.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/pepper/usb_key_code_conversion.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/usb_key_code_conversion_linux.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/usb_key_code_conversion_mac.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/usb_key_code_conversion_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/pepper/v8_var_converter.h View 1 2 3 4 5 1 chunk +10 lines, -10 lines 0 comments Download
A + content/renderer/pepper/v8_var_converter.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + content/renderer/pepper/v8_var_converter_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 4 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
D webkit/plugins/ppapi/DEPS View 1 2 3 4 5 1 chunk +0 lines, -11 lines 0 comments Download
D webkit/plugins/ppapi/OWNERS View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download
D webkit/plugins/ppapi/audio_helper.h View 1 2 3 4 5 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/plugins/ppapi/audio_helper.cc View 1 2 3 4 5 1 chunk +0 lines, -87 lines 0 comments Download
D webkit/plugins/ppapi/common.h View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/plugins/ppapi/content_decryptor_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -195 lines 0 comments Download
D webkit/plugins/ppapi/content_decryptor_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -1048 lines 0 comments Download
D webkit/plugins/ppapi/event_conversion.h View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/plugins/ppapi/event_conversion.cc View 1 2 3 4 5 1 chunk +0 lines, -735 lines 0 comments Download
D webkit/plugins/ppapi/fullscreen_container.h View 1 2 3 4 5 1 chunk +0 lines, -47 lines 0 comments Download
D webkit/plugins/ppapi/gfx_conversion.h View 1 2 3 4 5 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/plugins/ppapi/host_array_buffer_var.h View 1 2 3 4 5 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/plugins/ppapi/host_array_buffer_var.cc View 1 2 3 4 5 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/plugins/ppapi/host_globals.h View 1 2 3 4 5 1 chunk +0 lines, -119 lines 0 comments Download
D webkit/plugins/ppapi/host_globals.cc View 1 2 3 4 5 1 chunk +0 lines, -285 lines 0 comments Download
D webkit/plugins/ppapi/host_var_tracker.h View 1 2 3 4 5 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/plugins/ppapi/host_var_tracker.cc View 1 2 3 4 5 1 chunk +0 lines, -173 lines 0 comments Download
D webkit/plugins/ppapi/host_var_tracker_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -138 lines 0 comments Download
D webkit/plugins/ppapi/message_channel.h View 1 2 3 4 5 1 chunk +0 lines, -123 lines 0 comments Download
D webkit/plugins/ppapi/message_channel.cc View 1 2 3 4 5 1 chunk +0 lines, -520 lines 0 comments Download
D webkit/plugins/ppapi/mock_platform_image_2d.h View 1 2 3 4 5 1 chunk +0 lines, -32 lines 0 comments Download
D webkit/plugins/ppapi/mock_platform_image_2d.cc View 1 2 3 4 5 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -197 lines 0 comments Download
D webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -427 lines 0 comments Download
D webkit/plugins/ppapi/mock_resource.h View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/plugins/ppapi/npapi_glue.h View 1 2 3 4 5 1 chunk +0 lines, -267 lines 0 comments Download
D webkit/plugins/ppapi/npapi_glue.cc View 1 2 3 4 5 1 chunk +0 lines, -357 lines 0 comments Download
D webkit/plugins/ppapi/npobject_var.h View 1 2 3 4 5 1 chunk +0 lines, -71 lines 0 comments Download
D webkit/plugins/ppapi/npobject_var.cc View 1 2 3 4 5 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/plugins/ppapi/plugin_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -712 lines 0 comments Download
D webkit/plugins/ppapi/plugin_module.h View 1 2 3 4 5 1 chunk +0 lines, -283 lines 0 comments Download
D webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 5 1 chunk +0 lines, -639 lines 0 comments Download
D webkit/plugins/ppapi/plugin_object.h View 1 2 3 4 5 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/plugins/ppapi/plugin_object.cc View 1 2 3 4 5 1 chunk +0 lines, -360 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_interface_factory.h View 1 2 3 4 5 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_interface_factory.cc View 1 2 3 4 5 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 1 chunk +0 lines, -105 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_plugin_instance_impl.h View 1 2 3 4 5 1 chunk +0 lines, -861 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_plugin_instance_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -2723 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_plugin_instance_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -127 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_unittest.h View 1 2 3 4 5 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -173 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_webplugin_impl.h View 1 2 3 4 5 1 chunk +0 lines, -117 lines 0 comments Download
D webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -308 lines 0 comments Download
D webkit/plugins/ppapi/ppb_audio_impl.h View 1 2 3 4 5 1 chunk +0 lines, -86 lines 0 comments Download
D webkit/plugins/ppapi/ppb_audio_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -161 lines 0 comments Download
D webkit/plugins/ppapi/ppb_broker_impl.h View 1 2 3 4 5 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/plugins/ppapi/ppb_broker_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/plugins/ppapi/ppb_buffer_impl.h View 1 2 3 4 5 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/plugins/ppapi/ppb_buffer_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -113 lines 0 comments Download
D webkit/plugins/ppapi/ppb_file_ref_impl.h View 1 2 3 4 5 1 chunk +0 lines, -127 lines 0 comments Download
D webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -511 lines 0 comments Download
D webkit/plugins/ppapi/ppb_flash_message_loop_impl.h View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/plugins/ppapi/ppb_flash_message_loop_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -113 lines 0 comments Download
D webkit/plugins/ppapi/ppb_gpu_blacklist_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/plugins/ppapi/ppb_gpu_blacklist_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 2 3 4 5 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -328 lines 0 comments Download
D webkit/plugins/ppapi/ppb_image_data_impl.h View 1 2 3 4 5 1 chunk +0 lines, -196 lines 0 comments Download
D webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -278 lines 0 comments Download
D webkit/plugins/ppapi/ppb_network_monitor_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -54 lines 0 comments Download
D webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -89 lines 0 comments Download
D webkit/plugins/ppapi/ppb_proxy_impl.h View 1 2 3 4 5 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -79 lines 0 comments Download
D webkit/plugins/ppapi/ppb_scrollbar_impl.h View 1 2 3 4 5 1 chunk +0 lines, -78 lines 0 comments Download
D webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -251 lines 0 comments Download
D webkit/plugins/ppapi/ppb_tcp_server_socket_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/plugins/ppapi/ppb_tcp_server_socket_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -53 lines 0 comments Download
D webkit/plugins/ppapi/ppb_tcp_socket_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -134 lines 0 comments Download
D webkit/plugins/ppapi/ppb_uma_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/plugins/ppapi/ppb_uma_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -100 lines 0 comments Download
D webkit/plugins/ppapi/ppb_var_deprecated_impl.h View 1 2 3 4 5 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/plugins/ppapi/ppb_var_deprecated_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -437 lines 0 comments Download
D webkit/plugins/ppapi/ppb_video_decoder_impl.h View 1 2 3 4 5 1 chunk +0 lines, -87 lines 0 comments Download
D webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -303 lines 0 comments Download
D webkit/plugins/ppapi/ppb_widget_impl.h View 1 2 3 4 5 1 chunk +0 lines, -64 lines 0 comments Download
D webkit/plugins/ppapi/ppb_widget_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -80 lines 0 comments Download
D webkit/plugins/ppapi/ppb_x509_certificate_private_impl.h View 1 2 3 4 5 1 chunk +0 lines, -37 lines 0 comments Download
D webkit/plugins/ppapi/ppb_x509_certificate_private_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/plugins/ppapi/ppp_pdf.h View 1 2 3 4 5 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/plugins/ppapi/quota_file_io.h View 1 2 3 4 5 1 chunk +0 lines, -117 lines 0 comments Download
D webkit/plugins/ppapi/quota_file_io.cc View 1 2 3 4 5 1 chunk +0 lines, -424 lines 0 comments Download
D webkit/plugins/ppapi/quota_file_io_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -500 lines 0 comments Download
D webkit/plugins/ppapi/resource_creation_impl.h View 1 2 3 4 5 1 chunk +0 lines, -153 lines 0 comments Download
D webkit/plugins/ppapi/resource_creation_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -317 lines 0 comments Download
D webkit/plugins/ppapi/resource_helper.h View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/plugins/ppapi/resource_helper.cc View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/plugins/ppapi/url_request_info_util.h View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/plugins/ppapi/url_request_info_util.cc View 1 2 3 4 5 1 chunk +0 lines, -205 lines 0 comments Download
D webkit/plugins/ppapi/usb_key_code_conversion.h View 1 2 3 4 5 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/plugins/ppapi/usb_key_code_conversion.cc View 1 2 3 4 5 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/plugins/ppapi/usb_key_code_conversion_linux.cc View 1 2 3 4 5 1 chunk +0 lines, -32 lines 0 comments Download
D webkit/plugins/ppapi/usb_key_code_conversion_mac.cc View 1 2 3 4 5 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/plugins/ppapi/usb_key_code_conversion_win.cc View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/plugins/ppapi/v8_var_converter.h View 1 2 3 4 5 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/plugins/ppapi/v8_var_converter.cc View 1 2 3 4 5 1 chunk +0 lines, -470 lines 0 comments Download
D webkit/plugins/ppapi/v8_var_converter_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -387 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 2 3 4 5 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
7 years, 5 months ago (2013-07-24 22:01:36 UTC) #1
scottmg
> ... > [[ 55 additional files ]] Ruh-roh.
7 years, 5 months ago (2013-07-24 22:03:14 UTC) #2
jam
On 2013/07/24 22:03:14, scottmg wrote: > > ... > > [[ 55 additional files ]] ...
7 years, 5 months ago (2013-07-24 22:06:49 UTC) #3
scottmg
lgtm i can't download the patch, but did you grep for WEBKIT_PLUGINS_EXPORT in content/renderer? https://codereview.chromium.org/20165002/diff/1/content/renderer/pepper/pepper_url_loader_host.cc ...
7 years, 5 months ago (2013-07-24 22:23:01 UTC) #4
jam
7 years, 5 months ago (2013-07-24 23:27:13 UTC) #5 
On 2013/07/24 22:23:01, scottmg wrote:
> lgtm
> 
> i can't download the patch, but did you grep for WEBKIT_PLUGINS_EXPORT in
> content/renderer?

yep, i had done that
> 
>
https://codereview.chromium.org/20165002/diff/1/content/renderer/pepper/peppe...
> File content/renderer/pepper/pepper_url_loader_host.cc (right):
> 
>
https://codereview.chromium.org/20165002/diff/1/content/renderer/pepper/peppe...
> content/renderer/pepper/pepper_url_loader_host.cc:7: 
> \n

done

Powered by Google App Engine
This is Rietveld 408576698