Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2016383002: Set PointerType of pointer event on Windows. (Closed)

Created:
4 years, 6 months ago by lanwei
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Set PointerType of pointer event on Windows. Pointer event's PointerType did not set on Windows for mouse type when converting from ui::MouseEvent to blink::WebMouseEvent. In WebMouseEventBuilder::Build for Windows, I set the pointer type of WebMouseEvent. BUG=605639 Review-Url: https://codereview.chromium.org/1993853002 Cr-Commit-Position: refs/heads/master@{#395999} (cherry picked from commit 8a78e7138f7fce8ce8bfe75803bbf8c33877da9a) Committed: https://chromium.googlesource.com/chromium/src/+/b8a16ac50c11d9325a4d20dbd617c721d13e180a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -33 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_win.h View 1 chunk +14 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_win.cc View 4 chunks +17 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 5 chunks +17 lines, -6 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurawin.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lanwei
4 years, 6 months ago (2016-05-27 16:14:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8a16ac50c11d9325a4d20dbd617c721d13e180a.

Powered by Google App Engine
This is Rietveld 408576698