Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2016353003: isolate_android_sdk: Find or download isolate binary, fix infra path (Closed)

Created:
4 years, 6 months ago by borenet2
Modified:
4 years, 6 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org, liyuqian
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

isolate_android_sdk: Find or download isolate binary, fix infra path BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016353003 Committed: https://skia.googlesource.com/skia/+/1346c25071ff0482958101c6f09063db6cd17cfe

Patch Set 1 #

Total comments: 2

Patch Set 2 : Non-linux platforms #

Patch Set 3 : Add check_isolate_auth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -6 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M infra/bots/isolate_android_sdk.py View 1 2 4 chunks +59 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
borenet
4 years, 6 months ago (2016-05-27 14:35:50 UTC) #3
rmistry
lgtm https://codereview.chromium.org/2016353003/diff/1/infra/bots/isolate_android_sdk.py File infra/bots/isolate_android_sdk.py (right): https://codereview.chromium.org/2016353003/diff/1/infra/bots/isolate_android_sdk.py#newcode31 infra/bots/isolate_android_sdk.py:31: 'tools', 'luci-go', 'linux64') What about the windows and ...
4 years, 6 months ago (2016-05-27 14:38:04 UTC) #4
borenet
Added support for other platforms as well as check_isolate_auth. https://codereview.chromium.org/2016353003/diff/1/infra/bots/isolate_android_sdk.py File infra/bots/isolate_android_sdk.py (right): https://codereview.chromium.org/2016353003/diff/1/infra/bots/isolate_android_sdk.py#newcode31 infra/bots/isolate_android_sdk.py:31: ...
4 years, 6 months ago (2016-05-27 14:50:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016353003/40001
4 years, 6 months ago (2016-05-27 17:56:17 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:11:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1346c25071ff0482958101c6f09063db6cd17cfe

Powered by Google App Engine
This is Rietveld 408576698