Convert controls-cast-* tests to testharness.js

Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/47293611986cb0cab0fb615e9300ef0be2c3329f
Cr-Commit-Position: refs/heads/master@{#396708}

[Srirama, 2016-05-27 13:56:42]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-27 13:58:37]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-27 14:01:14]

Patchset #1 (id:20001) has been deleted

[Srirama, 2016-05-27 14:02:46]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com, philipj@opera.com

[Srirama, 2016-05-27 14:02:46]

PTAL.
These tests are already using testharness framework, i just cleaned up a bit.

[fs, 2016-05-27 14:30:06]

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-button.html (right):

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:10: {
Should we go with

async_test(function(t) {

style now perhaps? (Here and all other cases below.)

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:66: function
castButtonDimensions(element)
These two functions (this one and the one below) seems like the could as well be
folded into the testcode (since the overlap is great between them.)

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html
(right):

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:23: //
Cast button shoud be visible
Nit: Typo "should" (not new, but since we're essentially rewriting...)

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:29: //
Cast button shoud be gone
Ditto.

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:40: 
Stray blank line.

[Srirama, 2016-05-27 16:46:38]

Patchset #2 (id:60001) has been deleted

[Srirama, 2016-05-27 16:49:57]

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-button.html (right):

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:10: {
On 2016/05/27 14:30:06, fs wrote:
> Should we go with
> 
> async_test(function(t) {
> 
> style now perhaps? (Here and all other cases below.)

Done.

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:66: function
castButtonDimensions(element)
On 2016/05/27 14:30:06, fs wrote:
> These two functions (this one and the one below) seems like the could as well
be
> folded into the testcode (since the overlap is great between them.)

Done.

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html
(right):

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:23: //
Cast button shoud be visible
On 2016/05/27 14:30:06, fs wrote:
> Nit: Typo "should" (not new, but since we're essentially rewriting...)

Done.

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:29: //
Cast button shoud be gone
On 2016/05/27 14:30:06, fs wrote:
> Ditto.

Done.

https://codereview.chromium.org/2016323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html:40: 
On 2016/05/27 14:30:06, fs wrote:
> Stray blank line.

Done.

[fs, 2016-05-27 17:09:02]

lgtm

https://codereview.chromium.org/2016323003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-button.html (right):

https://codereview.chromium.org/2016323003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:32: var position
= new Array(x, y);
Nit: position[1] (y) isn't used, so just using 'x' instead of position[0] (and
not compute 'y' or create 'position') ought to be enough.

[Srirama, 2016-05-27 17:39:46]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org
- philipj@opera.com

[Srirama, 2016-05-27 17:39:46]

adding correct id of philip

https://codereview.chromium.org/2016323003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-cast-button.html (right):

https://codereview.chromium.org/2016323003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-cast-button.html:32: var position
= new Array(x, y);
On 2016/05/27 17:09:02, fs wrote:
> Nit: position[1] (y) isn't used, so just using 'x' instead of position[0] (and
> not compute 'y' or create 'position') ought to be enough.

Done.

[Srirama, 2016-05-30 09:56:48]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-05-30 09:56:49]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2016323003/#ps100001
(title: "address nit")

[commit-bot: I haz the power, 2016-05-30 09:56:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016323003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016323003/100001

[commit-bot: I haz the power, 2016-05-30 10:53:27]

Description was changed from

==========
Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-30 10:53:28]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-05-30 10:54:44]

Description was changed from

==========
Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert controls-cast-* tests to testharness.js

Cleaning up controls-cast-* tests in media/ to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/47293611986cb0cab0fb615e9300ef0be2c3329f
Cr-Commit-Position: refs/heads/master@{#396708}
==========

[commit-bot: I haz the power, 2016-05-30 10:54:45]

Patchset 3 (id:??) landed as
https://crrev.com/47293611986cb0cab0fb615e9300ef0be2c3329f
Cr-Commit-Position: refs/heads/master@{#396708}