Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2016323002: Remove rtc_peer_connection_handler.cc's OverrideDefaultCertificate (Closed)

Created:
4 years, 6 months ago by hbos_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove rtc_peer_connection_handler.cc's OverrideDefaultCertificate which was used to override the default DTLS certificate to use in WebRTC to ECDSA. This is no longer needed since KT_DEFAULT == KT_ECDSA, meaning ECDSA is already the default certificate and calling this function does nothing. BUG=601850, 611698 Committed: https://crrev.com/2c8d51533a9a774650bc2f728cee2c9e97fb70a4 Cr-Commit-Position: refs/heads/master@{#396460}

Patch Set 1 #

Patch Set 2 : Removing unnecessary #include, no need to re-run trybots yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hbos_chromium
Please take a look, tommi.
4 years, 6 months ago (2016-05-27 11:44:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016323002/1
4 years, 6 months ago (2016-05-27 11:45:07 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-05-27 11:59:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016323002/20001
4 years, 6 months ago (2016-05-27 12:12:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 14:13:58 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 14:16:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c8d51533a9a774650bc2f728cee2c9e97fb70a4
Cr-Commit-Position: refs/heads/master@{#396460}

Powered by Google App Engine
This is Rietveld 408576698