Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2016313003: Adds unit tests for Offliner SavePage implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed Fake* to Stub* and added files to proper build target Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_offliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 08d0a665b520408c5f681165b72525cdb87a47d0..75376ac6e6723163408834b51cb15afc493f229d 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -42,11 +42,6 @@ class PrerenderingOffliner : public Offliner {
void SetLoaderForTesting(std::unique_ptr<PrerenderingLoader> loader);
protected:
- // Internal method for OfflinePageModel's check if url can be saved.
- // Exposed for unit testing.
- // TODO(dougarnett): Consider making OfflinePageModel mockable instead.
- virtual bool CanSavePage(const GURL& url);
-
// Internal method for requesting OfflinePageModel to save page.
// Exposed for unit testing.
// TODO(dougarnett): Consider making OfflinePageModel mockable instead.
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_offliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698