components/offline_pages/BUILD.gn - Issue 2016313003: Adds unit tests for Offliner SavePage implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/BUILD.gn

Issue 2016313003: Adds unit tests for Offliner SavePage implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build.gn file name and lint Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/components_tests.gyp ('k') | components/offline_pages/fake_offline_page_model.h » ('j') | components/offline_pages/fake_offline_page_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/BUILD.gn

diff --git a/components/offline_pages/BUILD.gn b/components/offline_pages/BUILD.gn

index 723a789d1550677250a58d85c3db4c8275eb47f5..3b9dc5ca8735900549ea7d87129a44f50186a114 100644

--- a/components/offline_pages/BUILD.gn

+++ b/components/offline_pages/BUILD.gn

@@ -78,6 +78,7 @@ source_set("unit_tests") {

sources = [

"archive_manager_unittest.cc",

"client_policy_controller_unittest.cc",

+ "fake_offline_page_model.h",

fgorski 2016/06/01 18:04:00 I think this belongs in test_support and componen

dougarnett 2016/06/01 20:28:28 Thanks - Done

"offline_page_metadata_store_impl_unittest.cc",

"offline_page_model_impl_unittest.cc",

"offline_page_storage_manager_unittest.cc",