Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3416)

Unified Diff: base/sequence_checker.h

Issue 20163004: base: Re-apply WeakPtr support for SequencedWorkerPools, fixing deadlock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back death test threadsafe mode flag that got lost. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump_io_ios.h ('k') | base/sequence_checker_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sequence_checker.h
diff --git a/base/sequence_checker.h b/base/sequence_checker.h
index fbf146ac502d3efd7dd26667cae291cbe501344f..89bbd7eca9250d2322f3e410da800a42a35729ae 100644
--- a/base/sequence_checker.h
+++ b/base/sequence_checker.h
@@ -28,12 +28,11 @@ class SequencedTaskRunner;
// the right version for your build configuration.
class SequenceCheckerDoNothing {
public:
- bool CalledOnValidSequence() const {
+ bool CalledOnValidSequencedThread() const {
return true;
}
- void ChangeSequence(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {}
+ void DetachFromSequence() {}
};
// SequenceChecker is a helper class used to help verify that some
@@ -44,10 +43,6 @@ class SequenceCheckerDoNothing {
// Example:
// class MyClass {
// public:
-// explicit MyClass(
-// const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner)
-// : sequence_checker_(sequenced_task_runner) {}
-//
// void Foo() {
// DCHECK(sequence_checker_.CalledOnValidSequence());
// ... (do stuff) ...
@@ -60,16 +55,9 @@ class SequenceCheckerDoNothing {
// In Release mode, CalledOnValidSequence will always return true.
#if ENABLE_SEQUENCE_CHECKER
class SequenceChecker : public SequenceCheckerImpl {
- public:
- explicit SequenceChecker(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner)
- : SequenceCheckerImpl(sequenced_task_runner) {}
};
#else
class SequenceChecker : public SequenceCheckerDoNothing {
- public:
- explicit SequenceChecker(
- const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {}
};
#endif // ENABLE_SEQUENCE_CHECKER
« no previous file with comments | « base/message_loop/message_pump_io_ios.h ('k') | base/sequence_checker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698