Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 20163: Don't try to force dotted lines to have a dot on both ends.... (Closed)

Created:
11 years, 10 months ago by Dean McNamee
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't try to force dotted lines to have a dot on both ends. This avoids needing to skip a dot in the middle, or to average / anti-alias the line. Both of these look worse than just skipping the ending dot. BUG=6398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M WebCore/platform/graphics/skia/PlatformContextSkia.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
Hey Brett, This is regarding the line dot antialiasing. See the bug for a comparison ...
11 years, 10 months ago (2009-02-08 14:40:39 UTC) #1
Dean McNamee
11 years, 10 months ago (2009-02-10 12:22:55 UTC) #2
This makes some cases look awful, for example

LayoutTests/css1/box_properties/border_style.html

The tradeoff is that matching at the corners makes box borders look better,
otherwise things look random, depending on which part of the border was the
stroke origin / etc.

I will think about it more.


On 2009/02/08 14:40:39, Dean McNamee wrote:
> Hey Brett,
> 
> This is regarding the line dot antialiasing.  See the bug for a comparison of
> the 3 different approaches, including the one in this patch.
> 
> http://code.google.com/p/chromium/issues/detail?id=6398
> 
> Thanks

Powered by Google App Engine
This is Rietveld 408576698