Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2016243003: Fix two bugs found by /analyze tool (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix two bugs found by /analyze tool The first one is about bitwise AND on zero, the result would always be zero. The second one is about using wrong bitmasks, the result would cause branches never get executed. BUG=chromium:613623, chromium:427616 Committed: https://pdfium.googlesource.com/pdfium/+/bbff41927ecce2ff93668aa615307f548ca896eb

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M xfa/fwl/theme/cfwl_formtp.cpp View 1 chunk +9 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-05-27 20:35:15 UTC) #3
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 21:40:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016243003/20001
4 years, 6 months ago (2016-05-27 21:47:56 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:48:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/bbff41927ecce2ff93668aa615307f548ca8...

Powered by Google App Engine
This is Rietveld 408576698