chrome/browser/ui/views/new_back_shortcut_bubble.cc - Issue 2016203002: Widget opacity goes from 0 to 1, not 0 to 255.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/new_back_shortcut_bubble.cc

Issue 2016203002: Widget opacity goes from 0 to 1, not 0 to 255. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resync Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/new_back_shortcut_bubble.cc

diff --git a/chrome/browser/ui/views/new_back_shortcut_bubble.cc b/chrome/browser/ui/views/new_back_shortcut_bubble.cc

index c43d3f46e3feee4597459bc9ccd1ece0f25df03a..a709cb402037b1a398a0bf5893ce9237092085bc 100644

--- a/chrome/browser/ui/views/new_back_shortcut_bubble.cc

+++ b/chrome/browser/ui/views/new_back_shortcut_bubble.cc

@@ -85,7 +85,7 @@ void NewBackShortcutBubble::UpdateContent(bool forward) {

void NewBackShortcutBubble::AnimationProgressed(

const gfx::Animation* animation) {

- int opacity = animation_->CurrentValueBetween(0, 255);

+ float opacity = static_cast<float>(animation_->CurrentValueBetween(0.0, 1.0));

if (opacity == 0) {

popup_->Hide();

} else {