Fix a browser crash when the URLRequestChromeJob goes away...

chrome/browser/dom_ui/chrome_url_data_manager.cc

Index: chrome/browser/dom_ui/chrome_url_data_manager.cc
===================================================================
--- chrome/browser/dom_ui/chrome_url_data_manager.cc	(revision 9407)
+++ chrome/browser/dom_ui/chrome_url_data_manager.cc	(working copy)
@@ -231,7 +231,7 @@
   // Forward this data on to the pending URLRequest, if it exists.
   PendingRequestMap::iterator i = pending_requests_.find(request_id);
   if (i != pending_requests_.end()) {
-    URLRequestChromeJob* job = i->second;
+    scoped_refptr<URLRequestChromeJob> job = i->second;
     pending_requests_.erase(i);
     job->DataAvailable(bytes);
   }
@@ -291,8 +291,8 @@
     int bytes_read;
     if (pending_buf_.get()) {
       CompleteRead(pending_buf_, pending_buf_size_, &bytes_read);
+      pending_buf_ = NULL;

[darin (slow to review), 2009/02/09 22:49:15]

so this part of the change is no longer needed right?

[rvargas (doing something else), 2009/02/09 23:01:52]

Correct, it's not really needed but now I sort of prefer it this way :). From
the point of view of this job, we're done with the buffer after CompleteRead()

       NotifyReadComplete(bytes_read);
-      pending_buf_ = NULL;
     }
   } else {
     // The request failed.