Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2016193002: [Media Router WebUI] Add test for search focus when switching windows (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Add test for search focus when switching windows This change adds a browser test for the following case: The user selects the search input and then presses the Escape key. The dialog is now in the sink list view but keyboard focus is still on the search input. The user switches to another window and then back to the dialog. The container should remain in the sink list view and should not transition to the filter view, even though a focus event is fired on the search input. BUG=592723 R=apacible@chromium.org Committed: https://crrev.com/89251be1f810dbf03e2a4a2865e20d982c0e6d05 Cr-Commit-Position: refs/heads/master@{#396415}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test comment explaining focus events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/test/data/webui/media_router/media_router_container_filter_tests.js View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
btolsch
I think I figured out a reasonable way to test the focus behavior. Although focusin ...
4 years, 7 months ago (2016-05-27 02:39:10 UTC) #1
apacible
lgtm + nit https://codereview.chromium.org/2016193002/diff/1/chrome/test/data/webui/media_router/media_router_container_filter_tests.js File chrome/test/data/webui/media_router/media_router_container_filter_tests.js (right): https://codereview.chromium.org/2016193002/diff/1/chrome/test/data/webui/media_router/media_router_container_filter_tests.js#newcode628 chrome/test/data/webui/media_router/media_router_container_filter_tests.js:628: window.dispatchEvent(blur); nit: Add a few comments ...
4 years, 7 months ago (2016-05-27 05:03:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016193002/20001
4 years, 7 months ago (2016-05-27 06:08:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-27 07:23:26 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 07:25:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89251be1f810dbf03e2a4a2865e20d982c0e6d05
Cr-Commit-Position: refs/heads/master@{#396415}

Powered by Google App Engine
This is Rietveld 408576698