Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2016183002: Promises: cleanup call to PromiseSet (Closed)

Created:
4 years, 7 months ago by gsathya
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Promises: cleanup call to PromiseSet This got left behind from the changes in https://codereview.chromium.org/2007803002/ PromiseSet only takes 3 arguments. BUG=v8:5046 Committed: https://crrev.com/dc28c14606ce7f334413a4c6d9832a3daa51e47d Cr-Commit-Position: refs/heads/master@{#36556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/js/promise.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016183002/1
4 years, 7 months ago (2016-05-27 02:24:56 UTC) #4
gsathya
4 years, 7 months ago (2016-05-27 02:25:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-27 02:53:57 UTC) #7
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-27 08:28:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016183002/1
4 years, 6 months ago (2016-05-27 18:00:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 18:02:28 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:05:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc28c14606ce7f334413a4c6d9832a3daa51e47d
Cr-Commit-Position: refs/heads/master@{#36556}

Powered by Google App Engine
This is Rietveld 408576698