Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2016163002:
Roll PDFium 490d612..54ab234 (Closed)
|
Created:
4 years, 7 months ago by Lei Zhang Modified:
4 years, 7 months ago Reviewers:
Oliver Chang CC:
chromium-reviews, Wei Li Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll PDFium 490d612..54ab234
https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234
TBR=ochang@chromium.org
Committed: https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6
Cr-Commit-Position: refs/heads/master@{#396368}
Patch Set 1 #Messages
Total messages: 14 (6 generated)
Description was changed from ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 BUG= TEST=bots ========== to ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org ==========
thestig@chromium.org changed reviewers: + ochang@chromium.org
TBR, we are a busy bunch.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016163002/1
lgtm
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org ========== to ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org ========== to ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org Committed: https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6 Cr-Commit-Position: refs/heads/master@{#396368} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6 Cr-Commit-Position: refs/heads/master@{#396368}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2010353002/ by ynovikov@chromium.org. The reason for reverting is: Looks like this breaks compilation on Win and Win x64..
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org Committed: https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6 Cr-Commit-Position: refs/heads/master@{#396368} ========== to ========== Roll PDFium 490d612..54ab234 https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 TBR=ochang@chromium.org Committed: https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6 Cr-Commit-Position: refs/heads/master@{#396368} ==========
Message was sent while issue was closed.
On 2016/05/27 03:34:47, ynovikov wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2010353002/ by mailto:ynovikov@chromium.org. > > The reason for reverting is: Looks like this breaks compilation on Win and Win > x64.. +weili FYI I'm guessing there's some build flag mismatch still. https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1052/steps/co... c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fwl\core\fwl_formimp.cpp(357): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fwl\core\fwl_formimp.cpp(357): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(511): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(511): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(515): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(804): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(824): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(828): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(854): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) c:\b\build\slave\win_x64\build\src\third_party\pdfium\xfa\fxfa\parser\cxfa_widgetdata.cpp(1740): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) I'm going to fix these and roll again.
Message was sent while issue was closed.
Next roll attempt: https://codereview.chromium.org/2018903002/ |
