Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: net/socket/ssl_client_socket_impl.cc

Issue 2016143002: Expose when PKP is bypassed in SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/transport_security_state_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_impl.cc
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
index 80ff994982f2d3e804266d8623bae1dd2e90b0d4..f1c94e7d8a55f3c3d69cbdea6d6ad08d4628962a 100644
--- a/net/socket/ssl_client_socket_impl.cc
+++ b/net/socket/ssl_client_socket_impl.cc
@@ -1356,7 +1356,10 @@ int SSLClientSocketImpl::DoVerifyCertComplete(int result) {
server_cert_verify_result_.public_key_hashes, server_cert_.get(),
server_cert_verify_result_.verified_cert.get(),
TransportSecurityState::ENABLE_PIN_REPORTS, &pinning_failure_log_)) {
- result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
+ if (server_cert_verify_result_.is_issued_by_known_root)
estark 2016/05/31 14:59:57 I think we need to apply the same logic to the cor
dadrian 2016/05/31 18:58:31 I implemented the same logic for QUIC, but I'm wor
+ result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
+ else
+ server_cert_verify_result_.cert_status |= CERT_STATUS_PKP_BYPASSED;
}
if (result == OK) {
« no previous file with comments | « net/http/transport_security_state_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698