net/spdy/spdy_session.cc - Issue 2016143002: Expose when PKP is bypassed in SSLInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 2016143002: Expose when PKP is bypassed in SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make CertVerifyResult Great Again. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index d316ea2cc457686d57c240b99bb31c2fcfb8ab60..0c97fa5daffdcc46a98037e92cc156b54847b097 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -658,7 +658,8 @@ bool SpdySession::CanPool(TransportSecurityState* transport_security_state,

// DISABLE_PIN_REPORTS is set here because this check can fail in

// normal operation without being indicative of a misconfiguration or

// attack. Port is left at 0 as it is never used.

- if (!transport_security_state->CheckPublicKeyPins(

+ if (ssl_info.is_issued_by_known_root &&

+ !transport_security_state->CheckPublicKeyPins(

HostPortPair(new_hostname, 0), ssl_info.is_issued_by_known_root,

ssl_info.public_key_hashes, ssl_info.unverified_cert.get(),

ssl_info.cert.get(), TransportSecurityState::DISABLE_PIN_REPORTS,