Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: net/http/transport_security_state.h

Issue 2016143002: Expose when PKP is bypassed in SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make CertVerifyResult Great Again. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index b74b78d64fdb60664dfd3de3b0c2cd41e420b0dc..02ac31b40007fb8f139f0e8d6d8a5ede672a2941 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -255,7 +255,8 @@ class NET_EXPORT TransportSecurityState
// These functions search for static and dynamic STS and PKP states, and
// invoke the functions of the same name on them. These functions are the
// primary public interface; direct access to STS and PKP states is best
- // left to tests.
+ // left to tests. The caller needs to handle the optional pinning override
+ // when is_issued_by_known_root is false.
bool ShouldSSLErrorsBeFatal(const std::string& host);
bool ShouldUpgradeToSSL(const std::string& host);
bool CheckPublicKeyPins(const HostPortPair& host_port_pair,
@@ -412,6 +413,7 @@ class NET_EXPORT TransportSecurityState
// Helper method for actually checking pins.
bool CheckPublicKeyPinsImpl(
const HostPortPair& host_port_pair,
+ bool is_issued_by_known_root,
const HashValueVector& hashes,
const X509Certificate* served_certificate_chain,
const X509Certificate* validated_certificate_chain,
@@ -452,6 +454,7 @@ class NET_EXPORT TransportSecurityState
// |validated_certificate_chain|.
bool CheckPinsAndMaybeSendReport(
const HostPortPair& host_port_pair,
+ bool is_issued_by_known_root,
const TransportSecurityState::PKPState& pkp_state,
const HashValueVector& hashes,
const X509Certificate* served_certificate_chain,

Powered by Google App Engine
This is Rietveld 408576698