net/quic/crypto/proof_verifier_chromium.cc - Issue 2016143002: Expose when PKP is bypassed in SSLInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 2016143002: Expose when PKP is bypassed in SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: optional nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/crypto/proof_verifier_chromium.cc

diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc

index eb5f20ae70d74a1d1ac194b7e95eba770a4d0136..529570af035963d78dbc15aacf4f000dccb84a61 100644

--- a/net/quic/crypto/proof_verifier_chromium.cc

+++ b/net/quic/crypto/proof_verifier_chromium.cc

@@ -335,7 +335,10 @@ int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) {

cert_verify_result.verified_cert.get(),

TransportSecurityState::ENABLE_PIN_REPORTS,

&verify_details_->pinning_failure_log)) {

- result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;

+ if (cert_verify_result.is_issued_by_known_root)

+ result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;

+ else

+ verify_details_->cert_verify_result.pkp_bypassed = true;

}

if (result != OK) {