Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: net/http/http_response_info_unittest.cc

Issue 2016143002: Expose when PKP is bypassed in SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add pkp_bypassed to SSLInfo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_response_info.h" 5 #include "net/http/http_response_info.h"
6 6
7 #include "base/pickle.h" 7 #include "base/pickle.h"
8 #include "net/http/http_response_headers.h" 8 #include "net/http/http_response_headers.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 EXPECT_FALSE(restored_response_info.unused_since_prefetch); 45 EXPECT_FALSE(restored_response_info.unused_since_prefetch);
46 } 46 }
47 47
48 TEST_F(HttpResponseInfoTest, UnusedSincePrefetchPersistTrue) { 48 TEST_F(HttpResponseInfoTest, UnusedSincePrefetchPersistTrue) {
49 response_info_.unused_since_prefetch = true; 49 response_info_.unused_since_prefetch = true;
50 HttpResponseInfo restored_response_info; 50 HttpResponseInfo restored_response_info;
51 PickleAndRestore(response_info_, &restored_response_info); 51 PickleAndRestore(response_info_, &restored_response_info);
52 EXPECT_TRUE(restored_response_info.unused_since_prefetch); 52 EXPECT_TRUE(restored_response_info.unused_since_prefetch);
53 } 53 }
54 54
55 TEST_F(HttpResponseInfoTest, PKPBypassPersisted) {
estark 2016/06/07 04:10:43 Can you add a similar test for when |pkp_bypassed|
dadrian 2016/06/07 17:48:22 Done.
56 response_info_.ssl_info.pkp_bypassed = true;
57 HttpResponseInfo restored_response_info;
58 PickleAndRestore(response_info_, &restored_response_info);
59 EXPECT_TRUE(restored_response_info.ssl_info.pkp_bypassed);
60 }
61
55 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredDefault) { 62 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredDefault) {
56 EXPECT_FALSE(response_info_.async_revalidation_required); 63 EXPECT_FALSE(response_info_.async_revalidation_required);
57 } 64 }
58 65
59 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredCopy) { 66 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredCopy) {
60 response_info_.async_revalidation_required = true; 67 response_info_.async_revalidation_required = true;
61 net::HttpResponseInfo response_info_clone(response_info_); 68 net::HttpResponseInfo response_info_clone(response_info_);
62 EXPECT_TRUE(response_info_clone.async_revalidation_required); 69 EXPECT_TRUE(response_info_clone.async_revalidation_required);
63 } 70 }
64 71
65 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredAssign) { 72 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredAssign) {
66 response_info_.async_revalidation_required = true; 73 response_info_.async_revalidation_required = true;
67 net::HttpResponseInfo response_info_clone; 74 net::HttpResponseInfo response_info_clone;
68 response_info_clone = response_info_; 75 response_info_clone = response_info_;
69 EXPECT_TRUE(response_info_clone.async_revalidation_required); 76 EXPECT_TRUE(response_info_clone.async_revalidation_required);
70 } 77 }
71 78
72 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredNotPersisted) { 79 TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredNotPersisted) {
73 response_info_.async_revalidation_required = true; 80 response_info_.async_revalidation_required = true;
74 net::HttpResponseInfo restored_response_info; 81 net::HttpResponseInfo restored_response_info;
75 PickleAndRestore(response_info_, &restored_response_info); 82 PickleAndRestore(response_info_, &restored_response_info);
76 EXPECT_FALSE(restored_response_info.async_revalidation_required); 83 EXPECT_FALSE(restored_response_info.async_revalidation_required);
77 } 84 }
78 85
79 } // namespace 86 } // namespace
80 87
81 } // namespace net 88 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698