Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 201613006: Introduces the new syntax for deferred loading (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 66c29e25b86a6f5bc40e605e9090ef5a623c27c1..de227575c0a4027edc6ed9ca70d32683eb2bc662 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -464,14 +464,16 @@ class ResolverTask extends CompilerTask {
return elements;
}
if (element.isSynthesized) {
- Element target = element.targetConstructor;
- // Ensure the signature of the synthesized element is
- // resolved. This is the only place where the resolver is
- // seeing this element.
- element.computeSignature(compiler);
- if (!target.isErroneous()) {
- compiler.enqueuer.resolution.registerStaticUse(
- element.targetConstructor);
+ if (isConstructor) {
karlklose 2014/03/17 14:05:00 Combine the conditions.
sigurdm 2014/03/19 12:46:30 I think you look at the wrong }.
sigurdm 2014/03/20 12:26:33 As you suggested I added an assertion if it is not
+ Element target = element.targetConstructor;
+ // Ensure the signature of the synthesized element is
+ // resolved. This is the only place where the resolver is
+ // seeing this element.
+ element.computeSignature(compiler);
+ if (!target.isErroneous()) {
+ compiler.enqueuer.resolution.registerStaticUse(
+ element.targetConstructor);
+ }
}
return _ensureTreeElements(element);
}

Powered by Google App Engine
This is Rietveld 408576698