Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 201613005: Better handling of constant-pool-like parts of the instruction stream. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Better handling of constant-pool-like parts of the instruction stream. This avoids e.g. trying to disassemble those parts, which could result in failed assertions. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19992

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/a64/assembler-a64.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 9 months ago (2014-03-17 12:15:17 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-17 13:20:38 UTC) #2
Sven Panne
6 years, 9 months ago (2014-03-17 13:32:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19992 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698