DevTools: Add context menu option for objects to save to temp variable.

DevTools: Add context menu option for objects to save to temp variable.

Adding ability to access objects from printed ObjectPropertySections (console, scopes pane and etc.).

BUG=306120
R=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169649

[pfeldman, 2014-03-17 15:36:43]

https://codereview.chromium.org/201613004/diff/1/Source/devtools/front_end/So...
File Source/devtools/front_end/SourcesPanel.js (right):

https://codereview.chromium.org/201613004/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:1485: var message = "Failed to save to
temp variable" + (error ? ": " + error : "");
UIString()

https://codereview.chromium.org/201613004/diff/1/Source/devtools/front_end/So...
Source/devtools/front_end/SourcesPanel.js:1553:
WebInspector.runtimeModel.evaluate("window", "", false, true, false, false,
didGetGlobalObject.bind(this));
Please implement it top-bottom for better readability.

[aandrey, 2014-03-19 11:53:23]

PTAL

[pfeldman, 2014-03-19 18:08:02]

lgtm

https://codereview.chromium.org/201613004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/SourcesPanel.js (right):

https://codereview.chromium.org/201613004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/SourcesPanel.js:1399:
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles()
? "Save to temp variable" : "Save to Temp Variable"),
this._saveToTempVariable.bind(this, remoteObject));
"Store as global variable"

[aandrey, 2014-03-20 09:21:21]

https://codereview.chromium.org/201613004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/SourcesPanel.js (right):

https://codereview.chromium.org/201613004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/SourcesPanel.js:1399:
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles()
? "Save to temp variable" : "Save to Temp Variable"),
this._saveToTempVariable.bind(this, remoteObject));
On 2014/03/19 18:08:03, pfeldman wrote:
> "Store as global variable"

Done.

[aandrey, 2014-03-20 09:24:22]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-20 09:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/201613004/40001

[commit-bot: I haz the power, 2014-03-20 09:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 09:28:15]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[aandrey, 2014-03-20 11:51:56]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-20 11:51:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/201613004/40001

[commit-bot: I haz the power, 2014-03-20 12:47:58]

Change committed as 169649