Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Issue 2016123002: Remove ScriptCallStack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2006893004
Patch Set: full stack trace Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
index 24854f94ee8885417257b5db09672fcfdb7fc13c..f347fe1a02d88c2b6a15bdb085c6d42a357a1d83 100644
--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
@@ -151,11 +151,11 @@ void WorkerWebSocketChannel::fail(const String& reason, MessageLevel level, Pass
return;
OwnPtr<SourceLocation> capturedLocation = SourceLocation::capture();
- if (!capturedLocation->isEmpty()) {
+ if (!capturedLocation->isUnknown()) {
// If we are in JavaScript context, use the current location instead
// of passed one - it's more precise.
m_bridge->fail(reason, level, std::move(capturedLocation));
- } else if (!location || location->isEmpty()) {
+ } else if (!location || location->isUnknown()) {
kozy 2016/05/27 00:44:16 Redundant !location check. Comment in header said
dgozman 2016/05/27 00:52:29 Done.
// No information is specified by the caller - use the url
// and the line number at the connection.
m_bridge->fail(reason, level, m_locationAtConnection->clone());

Powered by Google App Engine
This is Rietveld 408576698