Issue 20161: Make aero glass code look more like other nonclient views in hopes of easing ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20161: Make aero glass code look more like other nonclient views in hopes of easing ... (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make aero glass code look more like other nonclient views in hopes of easing refactoring. More cleanup. Change tabstrip layout to match opaque frame. BUG=5054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9433

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -284 lines)			Patch
M	chrome/browser/views/constrained_window_impl.cc	View	1	6 chunks	+5 lines, -24 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_frame.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/aero_glass_frame.cc	View	1	4 chunks	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_non_client_view.h	View	1	1 chunk	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_non_client_view.cc	View	1	8 chunks	+126 lines, -195 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_non_client_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/opaque_non_client_view.cc	View	1	4 chunks	+5 lines, -14 lines	0 comments	Download
M	chrome/views/custom_frame_window.cc	View	1	4 chunks	+5 lines, -14 lines	0 comments	Download
M	chrome/views/non_client_view.h	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/views/non_client_view.cc	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM